Skip to content

[Security] Harden takeRandomFromArray with CSPRNG#7989

Draft
gonzaloriestra wants to merge 1 commit into
mainfrom
security-harden-take-random-17267358148401281979
Draft

[Security] Harden takeRandomFromArray with CSPRNG#7989
gonzaloriestra wants to merge 1 commit into
mainfrom
security-harden-take-random-17267358148401281979

Conversation

@gonzaloriestra

Copy link
Copy Markdown
Contributor

This PR hardens the takeRandomFromArray utility function by replacing the insecure Math.random() with globalThis.crypto.getRandomValues().

Key changes:

  • Switched to CSPRNG (globalThis.crypto.getRandomValues).
  • Implemented rejection sampling to eliminate modulo bias.
  • Added a guard for empty arrays to prevent errors.
  • Added unit tests to verify the fix and ensure no regressions.

PR created automatically by Jules for task 17267358148401281979 started by @gonzaloriestra

Replace Math.random() with globalThis.crypto.getRandomValues() in
takeRandomFromArray to use a cryptographically secure pseudo-random
number generator.

Implemented rejection sampling to avoid modulo bias and ensure a
uniform distribution across the array elements. Added a safety guard
for empty arrays.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant