[Security] Harden takeRandomFromArray with CSPRNG#7989
Conversation
Replace Math.random() with globalThis.crypto.getRandomValues() in takeRandomFromArray to use a cryptographically secure pseudo-random number generator. Implemented rejection sampling to avoid modulo bias and ensure a uniform distribution across the array elements. Added a safety guard for empty arrays.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR hardens the
takeRandomFromArrayutility function by replacing the insecureMath.random()withglobalThis.crypto.getRandomValues().Key changes:
globalThis.crypto.getRandomValues).PR created automatically by Jules for task 17267358148401281979 started by @gonzaloriestra