Skip to content

Use relative GraphiQL asset paths#8010

Open
alfonso-noriega wants to merge 1 commit into
mainfrom
07-06-graphiql-relative-assets
Open

Use relative GraphiQL asset paths#8010
alfonso-noriega wants to merge 1 commit into
mainfrom
07-06-graphiql-relative-assets

Conversation

@alfonso-noriega

@alfonso-noriega alfonso-noriega commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

No issue.

The cli-kit lint job started failing on GraphiQL asset resolution because Nx now rejects resolving files from the same project through the package export path.

WHAT is this pull request doing?

Resolve the GraphiQL favicon and stylesheet through relative require.resolve paths instead of @shopify/cli-kit/assets/... package paths.

The CLI bundle step rewrites those asset lookups, so this also updates the GraphiQL bundling plugin to recognize the new relative asset paths.

How to test your changes?

  • pnpm nx run cli-kit:lint --skip-nx-cache
  • pnpm nx run cli-kit:type-check --skip-nx-cache
  • pnpm nx run-many --all --skip-nx-cache --target=build --output-style=stream
  • pnpm nx run-many --all --skip-nx-cache --target=bundle --output-style=stream

Post-release steps

None.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

Not user-facing; no changeset needed.

@alfonso-noriega alfonso-noriega requested a review from a team as a code owner July 6, 2026 17:26

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 6, 2026
@alfonso-noriega alfonso-noriega force-pushed the 07-06-graphiql-relative-assets branch 2 times, most recently from b2f834b to f0ac166 Compare July 9, 2026 12:56
@alfonso-noriega alfonso-noriega force-pushed the 07-06-graphiql-relative-assets branch from f0ac166 to 58ae9d1 Compare July 9, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants