Matter Lock: Re-profile a Lock if it requires an unlatch embedded config#2945
Merged
hcarter-775 merged 2 commits intomainfrom May 4, 2026
Merged
Conversation
|
Channel deleted. |
Test Results 72 files 506 suites 0s ⏱️ For more details on these failures, see this check. Results for commit 2c5714c. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 2c5714c |
ldeora
reviewed
May 4, 2026
|
Tested it with a real device (while not being at home! No risk, no fun!) and it works. |
ctowns
approved these changes
May 4, 2026
Contributor
ctowns
left a comment
ctowns
left a comment
There was a problem hiding this comment.
Thank you @hcarter-775 and @ldeora!
hcarter-775
force-pushed
the
fix/update-lock-profile-if-unlatch-supported
branch
from
6788222 to
2c5714c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Issue reported: #2940
In latest production release last week, a profiling bug related to a subset of Nuki devices supporting UNLATCH was introduced which led the embedded config for these devices to not be exposed, since the capabilities may not have explicitly changed, though their fingerprints did not initially include the unlatch embedded configs.
Summary of Completed Tests
New unit test added to match the Nuki Ultra Lock profiling behavior.