fix(workout-builder): require all inferred exercise equipment - #248
Open
evan188199-tech wants to merge 1 commit into
Open
evan188199-tech wants to merge 1 commit into
evan188199-tech wants to merge 1 commit into
Conversation
|
Someone is attempting to deploy a commit to the Workoutcool Team Team on Vercel. A member of the Team first needs to authorize it. |
evan188199-tech
force-pushed
the
codex/equipment-requirements
branch
from
August 19, 2026 13:39
d1bad2f to
6caa63d
Compare
evan188199-tech
marked this pull request as ready for review
August 19, 2026 13:40
evan188199-tech
force-pushed
the
codex/equipment-requirements
branch
from
August 19, 2026 13:46
6caa63d to
cd2a535
Compare
Author
|
@Snouzy Could you please approve the fork workflow run and take a look when you have a chance? The branch is rebased on the latest |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--apply.Why
Some exercises are tagged only with their primary equipment even though their instructions require another item. For example, a dumbbell bench press can still appear for a dumbbell-only selection because the current query treats multiple equipment tags as an OR match.
Safety
The backfill only appends missing inferred tags and never removes existing tags. The importer drops stale
BODY_ONLYfrom the resolved equipment set only when another material requirement was inferred, so pure bodyweight movements remain unchanged.Tests
pnpm install --frozen-lockfilepnpm testpnpm exec tsc --noEmitgit diff --check