Repository navigation
elf_load_note validate the minimum note size as well, provided by the caller - #687
Merged
Merged
Conversation
… caller Found by scrutineer run by @avsm
reynir
reviewed
Oct 15, 2026
reynir
left a comment
reynir
left a comment
Contributor
There was a problem hiding this comment.
Looks fine to me other than a minor nit. This could also be checked at call sites with the out_note_size, but I think this is fine.
| if (note_size <= 0 || note_size > nhdr.h.n_descsz) { | ||
| if (note_size < min_note_size || note_size > nhdr.h.n_descsz) { | ||
| warnx("%s: INV_EXE: phdr[%u] note does not fall within valid size" | ||
| " (%zu <= 0 || %zu > %u)", |
Contributor
There was a problem hiding this comment.
This message should be updated - we no longer compare against 0 but min_note_size
reynir
approved these changes
Oct 15, 2026
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by scrutineer run by @avsm