engine: fix an overflow if combination of MAX_EDICT_BITS & DELTASIZE_BITS is too much#173
Open
RaphaelIT7 wants to merge 1 commit into
Open
engine: fix an overflow if combination of MAX_EDICT_BITS & DELTASIZE_BITS is too much#173RaphaelIT7 wants to merge 1 commit into
RaphaelIT7 wants to merge 1 commit into
Conversation
dimhotepus
force-pushed
the
master
branch
2 times, most recently
from
1319e7e to
08258ce
Compare
dimhotepus
force-pushed
the
master
branch
5 times, most recently
from
cd20eea to
71389bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nice to have to avoid future issues, as I've encountered this/went over 32 bits causing WriteUBitLong to fail.