Merge fixes: 1. Enforce SQLite foreign keys in model runtime 2. Move early in model code validation of number of sub-values not exceeding max RNG streams.#14
Open
amc1999 wants to merge 3 commits into
Conversation
…mber of sub-values typically should not exceeding number of random streams. Check it at RunOnce to detect error before getting model run parameters, to avoid long wait and excessive database read-write.
…ceeding number of sub-values
Collaborator
Author
|
@barnzilla But GitHub StatCan/stcopenmpp seems to be don't have my previous commits and only option is to merge most recent issue #15 with 2 previous commits. Technically I can fork StatCan/stcopenmpp again and apply my one line change to it, but that sounds strange. Any other suggestions? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves StatCan/stcopenmpp #15, resolves StatCan/stcopenmpp #12, resolves StatCan/stcopenmpp #13