Add thematic categories with icons to the shortcuts window#12374
Merged
Conversation
Reworks the shortcuts options window per the discussion in #12316: - New display-only ShortcutGroup (General, File, Video, Waveform, subtitle grid, text box, grid+text box, Sync, Translate, Search, Tools, AI) - the existing ShortcutCategory still drives dispatch and is now shown as "Active in" - Group filter tile strip (icon, name, count per group, plus All) - Grid columns: Active in | group icon | Category | Name | Shortcut - 145 shortcuts re-tagged out of the General bucket Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- "Active in" as outlined pill, dimmed for "Everywhere" so scoped shortcuts stand out - Shortcut keys as right-aligned keycap chips; unassigned rows show a dim italic "Unassigned" - Group icon in rows on a soft tinted square; filter tiles get a colored glyph square with white icon - Count badge tinted with the system accent color - Edit panel: selected shortcut name left, key controls right - Button bar: Import from SE4 + Reset left, OK/Cancel right Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- Category name rendered in its group color (medium weight) - Row icon square: stronger tint (0.16 -> 0.28 alpha), 24px with 16px icon - Name column semibold so the command name is the visual anchor Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #12316.
Design prototype that this implements: category tile filter + icon column + "Active in" context column.
What changed
ShortcutGroup): General, File, Video, Waveform, Subtitle list view, Text box, Grid + text box, Synchronization, Translate, Search, Tools, AI. It is display-only — the existingShortcutCategorystill drives dispatch/hashing and is untouched.AddShortcut, so adjusting a shortcut's group later is a one-word change.CategoryFile,CategoryVideo, …,ActiveIn,ActiveInEverywhere); other languages fall back to the English defaults until translated.Notes for review
ShortcutGroupUi.GetBrush).🤖 Generated with Claude Code