Skip to content

Strip "Release" subfolder when unpacking whisper.cpp engines (#12220) #12378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niksedk merged 1 commit into from
Jul 12, 2026
Merged

Strip "Release" subfolder when unpacking whisper.cpp engines (#12220) #12378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/ui/Features/Video/SpeechToText/Engines/WhisperEngineCpp.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,12 @@ public List<WhisperModel> Models
}

public string Extension => ".bin";
public string UnpackSkipFolder => string.Empty;

// The Windows whisper.cpp release (whisper-blas-bin-x64.zip) nests all binaries under a
// "Release/" folder, so whisper-cli.exe would otherwise land in Cpp/Release/ (see #12220).
// The Mac/Linux archives are flat; skipping "Release" is a no-op there because the unpacker
// only strips the prefix from entries that actually start with it.
public string UnpackSkipFolder => "Release";

public bool IsEngineInstalled()
{
Expand Down
6 changes: 5 additions & 1 deletion src/ui/Features/Video/SpeechToText/Engines/WhisperEngineCppVulkan.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,11 @@ public List<WhisperModel> Models
}

public string Extension => ".bin";
public string UnpackSkipFolder => string.Empty;

// Consistent with the other whisper.cpp engines: strip a leading "Release/" folder if the
// archive nests binaries in one (see #12220). No-op for the flat Vulkan archive because the
// unpacker only strips the prefix from entries that actually start with it.
public string UnpackSkipFolder => "Release";

public bool IsEngineInstalled()
{
Expand Down