Repository navigation
Support explicit ClickHouse credential sources and LZ4 - #4
Merged
Merged
Conversation
Keep existing Infisical precedence by default. Allow environment-owned bindings without credential fallback and apply opt-in LZ4 through driver options while preserving TLS and connection settings. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: theboringhumane <me@iamharsh.dev>
theboringhumane
marked this pull request as ready for review
October 10, 2026 06:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platform-provided ClickHouse connections can now use
CLICKHOUSE_DSN_SOURCE=environment. This mode requires a nonempty environment DSN and ignores the Infisical DSN. The default keeps existing Infisical-first behavior.CLICKHOUSE_COMPRESSION=lz4overrides only the driver's compression method and level. Leaving it unset preserves the DSN settings. TLS verification, credentials, timeouts and pool settings remain intact. Existing constructors retain their behavior.Focused tests cover credential-source precedence, missing or invalid options, development-mode validation, TLS/settings preservation, and redacted DSN parse errors. Formatting and whitespace checks passed; existing CI runs build, vet and tests.
This change does not update the separate Enterprise image. Its workflow must later pin the reviewed merged core commit and qualify the resulting image.