Open
Conversation
siwelwerd
commented
Apr 24, 2026
Comment on lines
+505
to
520
| <image xml:id="LE1-image-intersection-planes-one" width="50%" component="print"> | ||
| <sageplot variant="3d" aspect="1.0"> | ||
| <xi:include href="./sage/LE1-image-intersection-planes-one.sage" parse="text"/> | ||
| </sageplot> | ||
| <description> | ||
| <p>Three planes are shown to intersect at a single point. An arrow points to the point of intersection at coordinates <m>(1,2,3)</m>.</p> | ||
| </description> | ||
| </image> | ||
| <image xml:id="LE1-image-intersection-planes-one" component="html"> | ||
| <sageplot variant="3d" aspect="1.0"> | ||
| <xi:include href="./sage/LE1-image-intersection-planes-one.sage" parse="text"/> | ||
| </sageplot> | ||
| <description> | ||
| <p>Three planes are shown to intersect at a single point. An arrow points to the point of intersection at coordinates <m>(1,2,3)</m>.</p> | ||
| </description> | ||
| </image> |
Contributor
Author
There was a problem hiding this comment.
@StevenClontz This is compiling fine by hand, but throwing an error in the preview build. It complains that there are two images with the same xml:id, but our publication files are all set up to include either the html component (default), or the print component.
Should these images get distinct xml:ids? Or is there a better way to do this.
siwelwerd
commented
Apr 26, 2026
Comment on lines
+33
to
+34
| parser=etree.XMLParser(recover=True) | ||
| root = etree.parse(f,parser=parser).getroot() |
Contributor
Author
There was a problem hiding this comment.
@StevenClontz This fixes the error being thrown by duplicate xmlids. The error was because the xml was being parsed strictly here before pretext was involved. Please review for any unintended consequences of this change
🚀 Preview available 🚀https://8056b7f1.tbil.pages.dev
|
🚀 Preview available 🚀https://b89863db.tbil.pages.dev
|
🚀 Preview available 🚀https://31abe633.tbil.pages.dev
|
🚀 Preview available 🚀https://66fdb44d.tbil.pages.dev
|
🚀 Preview available 🚀https://3834ec04.tbil.pages.dev
|
🚀 Preview available 🚀https://e3da8b08.tbil.pages.dev
|
🚀 Preview available 🚀https://abfddda2.tbil.pages.dev
|
🚀 Preview available 🚀https://1989cfbc.tbil.pages.dev
|
🚀 Preview available 🚀https://bd26e5ce.tbil.pages.dev
|
🚀 Preview available 🚀https://bf3f3e87.tbil.pages.dev
|
🚀 Preview available 🚀https://79a54282.tbil.pages.dev
|
🚀 Preview available 🚀https://3d918416.tbil.pages.dev
|
🚀 Preview available 🚀https://aa0e4da0.tbil.pages.dev
|
🚀 Preview available 🚀https://49748c59.tbil.pages.dev
|
Contributor
Author
|
The LaTeX build still reports a few overfull hboxes, but I have looked at them and I think they are okay visually. So I believe this is ready to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #962