Open
Conversation
🚀 Preview available 🚀 |
siwelwerd
commented
Apr 28, 2026
Comment on lines
+57
to
+67
| <!-- looks bad when bibliographic number gets wrapped in [] --> | ||
| <!-- and the number should suffice on its own --> | ||
| <xsl:when test="$target/self::biblio"/> | ||
| <!-- and trailing a () for an equation number is overkill --> | ||
| <xsl:when test="$target/self::mrow|$target/self::md"/> | ||
| <!-- and it is really bad for an xref inside a title --> | ||
| <xsl:when test="ancestor::title"/> | ||
| <!-- off by default electronic PDF, --> | ||
| <!-- or on by default for print PDF --> | ||
| <xsl:when test="not($b-pageref)"/> | ||
| <!-- OK, requested and helps, let's add it --> |
Contributor
Author
There was a problem hiding this comment.
I'm not sure this is strictly needed, it is copied from the PreTeXt xsl. I think it is more future-proof to include it though so we are not inadvertently overriding this behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default way of displaying references in PDF is
This changes the behavior to have a parenthetical instead
HTML output is unaffected since it does not use this xsl file.