Skip to content

Added my "MusicBrainz" extension#1015

Open
samuellouf wants to merge 18 commits into
TurboWarp:masterfrom
samuellouf:MusicBrainz
Open

Added my "MusicBrainz" extension#1015
samuellouf wants to merge 18 commits into
TurboWarp:masterfrom
samuellouf:MusicBrainz

Conversation

@samuellouf

Copy link
Copy Markdown
Contributor

I added my "MusicBrainz" extension.
Here are the blocks:
Blocks

Enjoy 😄 !

Added most of the "search artist" feature
Added feature "search artist"
Added "search recording" feature
Added "search event" feature.
Added "Coming soon : 
advanced blocks button"
Added this file
Edited MusicBrainz.md
Edited "hasOwn()" function
Edited "hasOwn()" function again.
Same as previous
Edited the "getCountryName()" function.
@samuellouf

Copy link
Copy Markdown
Contributor Author

I got past eslint !
YAY!

@SharkPool-SP

Copy link
Copy Markdown
Collaborator

Whats the point of this

@snowboyz0825

Copy link
Copy Markdown

I got past eslint ! YAY!

Where does it pull the data from, out of cutiousity?

@oketariq

Copy link
Copy Markdown
Contributor

I got past eslint ! YAY!

Where does it pull the data from, out of cutiousity?

https://musicbrainz.org

@BlueDome77

Copy link
Copy Markdown

What about a block that could pull album artwork?

@GarboMuffin GarboMuffin added the pr: new extension Pull requests that add a new extension label Oct 14, 2024
@Brackets-Coder

Copy link
Copy Markdown
Contributor

putting #1143 and this as duplicates in #2271

@SharkPool-SP

Copy link
Copy Markdown
Collaborator

I wouldn't consider it a dup.

The Spotify extension is for Spotify songs only and everything surrounding that. musicbrainz is for a lot of other songs from other platforms. Musicbrainz does not have all Spotify songs on their platform

@Brackets-Coder

Brackets-Coder commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

I wouldn't consider it a dup.

The Spotify extension is for Spotify songs only and everything surrounding that. musicbrainz is for a lot of other songs from other platforms. Musicbrainz does not have all Spotify songs on their platform

It's a nuanced technicality, and even though they're both unique and different platforms they share similar ideas. Not quite a duplicate, but similar to the already resolved:

"#2389 and #2423 — somewhat similar, but different context/nuance"

@SharkPool-SP

Copy link
Copy Markdown
Collaborator

I think that's a bit far fetched given the block palettes

@Brackets-Coder

Copy link
Copy Markdown
Contributor

ok, they seem similar to me but perhaps I'm just overthinking it

@GarboMuffin
GarboMuffin requested a review from a team as a code owner July 13, 2026 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: new extension Pull requests that add a new extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants