Repository navigation
Conversation
…function/ Four references tell an authoring agent to read the minted `resource.key` from `resources/solution_folder/process/agent/<project>.json`. That file is not written for a CODED agent. `uip solution projects add` infers project type from the manifest it finds — `project.uiproj`, `project.json`, or `uipath.json` — and has no flag to override it. A coded agent scaffolded by `uip codedagent new` has only `uipath.json`, which is indistinguishable from a Function project's, so the resource lands at `process/function/<project>.json` with `spec.type: "Function"` and `uip solution projects list` reports `Type: Function`. Observed on CLI 1.203.0-dev.8669: a coder-eval run spent 18 turns and 167s trying to make the documented path appear — removing and re-adding the project, hand-editing `uipath.json`, deleting and regenerating the resource files. It never appeared, and the run finished by inventing a GUID that `uip maestro flow validate` accepted, because validate does not check that a well-formed key resolves on the tenant. So each site now: - names `uip maestro flow registry list --local` as the source to read the key FROM, rather than one of two equal options; - globs for the resource file (`process/*/<project>.json`) instead of hard-coding a directory, so it survives the classification being fixed; - states that `Type: Function` on a coded agent is that classification and not a scaffolding mistake, so it is not "corrected" before wiring; - says never to substitute a hand-written GUID, and why validate won't catch one. `uip codedagent run` in the troubleshooting table is also qualified: it executes the graph, so it needs UIPATH_ACCESS_TOKEN and LLM-gateway reach, and where those are absent its import and virtualenv errors are environment rather than project defects. `uip codedagent review` is named as the offline rung. LOW-CODE agent projects are deliberately untouched. They carry `agent.json` plus `project.uiproj`, so the classification is plausibly correct there and `process/agent/` may well be right — unverified, so left alone. The underlying CLI behaviour looks like a defect: the classifier could read `uipath.json`'s `agents` vs `functions` map instead of keying on the filename. Filed separately; this change makes the guidance true meanwhile. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Claude finished @dmetzgar's task in 2m 34s —— View job PR Review: fix(agents,maestro-flow): coded-agent resource path
SummaryCorrects four documentation sites across Change-by-Change Review1.
|
| Area | Status | Notes |
|---|---|---|
| Frontmatter | OK | No frontmatter changes |
| E2E Tests | Issue | Existing tests hard-code the old process/agent/ path — see What's Missing. Not introduced by this PR but now inconsistent with the updated guidance. |
| Skill Body | OK | No SKILL.md changes |
| References & Assets | OK | All four changed references are correct, internally consistent, and well-written |
| Repo Hygiene | OK | No secrets, no broken links, no cross-skill structural dependencies, changes scoped to the two affected skills |
Issues for Manual Review
- CLI behavior verification: The PR states this was observed on CLI
1.203.0-dev.8669. Worth confirming theprocess/function/classification still holds on the current stable CLI release — if it's been fixed upstream, the glob guidance is still correct (resilient) but the "today underfunction/" qualifications would need updating. - Low-code agent classification: The PR intentionally leaves
process/agent/in all low-code references. Worth confirming low-code agents withagent.json+project.uiprojdo indeed land underprocess/agent/as expected — if they also land underfunction/, the lowcode references have the same bug.
Conclusion
Clean, well-scoped fix. All four documentation sites are updated consistently — the glob pattern, the classification explanation, and the GUID warning are present at every site. The PR description is unusually thorough and clearly documents what was and wasn't changed, and why. No issues in the changed files themselves.
The main gap is the test files that still hard-code the old path, but those are pre-existing and explicitly out of scope. I'd suggest tracking them as a follow-up issue. Approve.
|
Closing this — it is the wrong fix, and it conflicts with better work. Superseded on 2 of the 4 files. #3165 already changes My causal claim here was also wrong. I said a coded agent's The two things in here that were real are independent of folder names and are not covered by #3165:
Both live in |
Four references tell an authoring agent to read the minted
resource.keyfromresources/solution_folder/process/agent/<project>.json. That file is not written for a coded agent.Why
uip solution projects addinfers project type from the manifest it finds —project.uiproj,project.json, oruipath.json— and has no flag to override it. A coded agent scaffolded byuip codedagent newhas onlyuipath.json, which is indistinguishable from a Function project's. So the resource lands atprocess/function/<project>.jsonwithspec.type: "Function", anduip solution projects listreportsType: Function.Observed on CLI
1.203.0-dev.8669. A coder-eval run spent 18 turns and 167s trying to make the documented path appear — removing and re-adding the project, hand-editinguipath.json, deleting and regenerating the resource files. It never appeared. The run finished by inventing a GUID, whichuip maestro flow validateaccepted, because validate does not check that a well-formed key resolves on the tenant.What changed
Each of the four sites now:
uip maestro flow registry list --localas the source to read the key from, rather than one of two equal options;process/*/<project>.json) instead of hard-coding a directory, so the guidance survives the classification being fixed;Type: Functionon a coded agent is that classification and not a scaffolding mistake, so it isn't "corrected" before wiring the Flow;validatewon't catch one.uip codedagent runin the troubleshooting table is also qualified: it executes the graph, so it needsUIPATH_ACCESS_TOKENand LLM-gateway reach, and where those are absent its import and virtualenv errors are environment rather than project defects.uip codedagent reviewis named as the offline rung.Scope
Low-code agent projects are deliberately untouched. They carry
agent.jsonplusproject.uiproj, so the classification is plausibly correct there andprocess/agent/may well be right. I did not verify that, so I left all ofreferences/lowcode/alone — it still saysprocess/agent/in several places, correctly as far as I know.Follow-up
The underlying CLI behaviour looks like a defect: the classifier could read
uipath.json'sagentsvsfunctionsmap rather than keying on the filename. Worth filing against the CLI; this change makes the guidance true in the meantime, and the glob means it stays true afterwards.Checks run
check-skill-verbs.py—uipath-maestro-flow38 findings / 0 blocking;uipath-agents73 / 0 blocking.maintenance/check-links.sh— 972 checked, 0 broken.maintenance/check-anchors.sh— 323 checked, 1 bad, pre-existing and unrelated:references/diagnose/troubleshooting-guide.md→../shared/cli-conventions.md#7-use-uip_log_levelinfo-for-debug-runs. Left alone rather than mixed into a guidance-correctness PR.Phase 0 of
UiPath/flow-builder-sdkdocs/SKILLS_PROMOTION_PLAN.md. The preview tree carries the same two wrong claims plus a "do not search for a published release" instruction; that side is fixed upstream in flow-builder-sdk and arrives here via the nightly Maestro SDK preview sync.🤖 Generated with Claude Code