Repository navigation
Conversation
A connection reset during the TLS handshake raised httpx.ConnectError, which the platform retry did not cover, so one dropped connection failed the whole call. A failed connect never sends the request, so it is safe to retry for any method. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019eqtRNhyPtxwyQUvKoK5Zy
github-actions
Bot
added
test:uipath-langchain
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019eqtRNhyPtxwyQUvKoK5Zy
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke: sometimes the network drops a connection while it is still being opened. That's like a phone call that hangs up before anyone says hello. The SDK already tries again when a call times out, but not when it hangs up like this. So one dropped connection made the whole step fail. This happened in our nightly tests (AGVSOL-7996): looking up a Coupa connection got
httpx.ConnectError: [Errno 104] Connection reset by peer, and the invoice step failed.The fix: treat
httpx.ConnectErroras something to retry, with the same backoff and attempt limit as timeouts.Why this is safe: a
ConnectErrormeans the request never left our side, because the connection wasn't up yet. Sending it again can't do anything twice, even for a POST. Errors that can happen after the server already got the request (ReadError,WriteError) are still not retried, and a test pins that.Testing:
ConnectError, for sync and async calls.ReadErroris not retried.uipath-platformsuite passes, and ruff and mypy are clean.uipath-platformto 0.2.35.