fix(hyperevm): cast-version-independent field reads, registry trap fix - #168
Open
david-uniswap wants to merge 1 commit into
Open
david-uniswap wants to merge 1 commit into
david-uniswap wants to merge 1 commit into
Conversation
…estore in the registry trap Follow-up to #164 review (non-blocking comments left with the approval): - merge_extra_deploys.py read cast --json, whose shape changed in cast 1.8 (wrapped in schema_version/success/data). Use the plain field accessors (cast receipt <tx> contractAddress|blockNumber, cast tx <tx> to|input), which print bare values on every version. - hyperevm.sh registry: the ERR trap copied several run-1*.json files to /dev/null, which only errors. It now copies the newest broadcast to run-latest.json explicitly. Registry step re-run against main's committed deployments/json/999.json: byte-identical. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two non-blocking comments Daniel left with his approval on #164, fixed here:
merge_extra_deploys.pyparsedcast receipt --json/cast tx --json, whose output shape changed in cast 1.8. It now uses the plain field accessors (cast receipt <tx> contractAddress|blockNumber,cast tx <tx> to|input), which print bare values on every version.ERRtrap inhyperevm.sh registrycopied severalrun-1*.jsonfiles to/dev/null, which only errors. It now restoresrun-latest.jsonto the newest broadcast explicitly.Re-ran the registry step against
main's committeddeployments/json/999.jsonwith the new script: byte-identical. Tooling only, no registry or contract changes.🤖 Generated with Claude Code