ITF export: Implement index batching support#550
Open
Krzmbrzl wants to merge 36 commits into
Open
Conversation
This function is of no real use to anyone using the generator from the outside. Hence, it shouldn't be part of its public API. Instead, it is now an implementation detail of the individual generators.
Krzmbrzl
force-pushed
the
export-index-batching
branch
from
78f43e7 to
ecabe24
Compare
Sorting changes the order of elements and hence the indices in cse_positions are no longer valid.
This produces an order that is more naturally suitable for potential future loop fusion.
ajay-mk
reviewed
Jun 18, 2026
|
|
||
| SEQUANT_ASSERT(end != std::ranges::end(label)); | ||
|
|
||
| std::basic_string_view<std::remove_cvref_t<std::ranges::range_value_t<View>>> view(&(*end), std::ranges::distance(end, std::ranges::end(label))); |
Member
There was a problem hiding this comment.
Formatting issue? Line 983 is too long. Also surprised the CI didn't flag it.
Collaborator
Author
There was a problem hiding this comment.
It's all run through the auto-formatter. So it's as formatted as it gets at least with this specific version of clang-format :D
|
|
||
| void end_named_section(std::string_view /*name*/, const Context &) override { | ||
| m_generated += "\n\n"; | ||
| if (!m_currentBatchIndices.empty()) { |
Member
There was a problem hiding this comment.
This logic for clearing batching indices is repeated in this file again. Maybe factor this out?
|
|
||
| void process_operation_queue() { | ||
| void process_operation_queue(const MainContext &ctx) { | ||
| IndexSpecificTensorBlockEqualComparator cmp( |
Member
There was a problem hiding this comment.
IndexSpecificTensorBlockEqualComparator is built similarly in other places also in this file. Is the comparator reusable?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.