fix(authentication): handle concurrent first-login race condition#732
Open
bencap wants to merge 1 commit into
Open
fix(authentication): handle concurrent first-login race condition#732bencap wants to merge 1 commit into
bencap wants to merge 1 commit into
Conversation
When multiple servers process a user's first login simultaneously, each may query, find no existing record, and attempt to INSERT. The losing request raised an unhandled IntegrityError. - Wrap the commit in a try/except IntegrityError block - On collision: rollback and re-fetch the existing user record - Add a test that simulates the race and asserts the correct user is returned with exactly one DB row
bencap
force-pushed
the
bugfix/bencap/703/get-current-user-race-condition
branch
from
9ede58a to
07c971b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple servers process a user's first login simultaneously, each may query, find no existing record, and attempt to INSERT. The losing request raised an unhandled IntegrityError.