Skip to content

fix(pitwall): handle missing structured RAG output - #1255

Merged
VforVitorio merged 1 commit into
devfrom
fix/1251-pitwall-rag-context
Sep 23, 2026
Merged

VforVitorio merged 1 commit into
devfrom
fix/1251-pitwall-rag-context

Conversation

@VforVitorio

Copy link
Copy Markdown
Owner

N30 can be routed in no-LLM mode without producing a structured RAG result. Keep that state distinct from a loaded answer, preserve legacy regulation text as unstructured context, and only build source tooltips from structured payloads. Empty structured results are no longer reported as loaded; retrieved chunks without an answer remain available with a WATCH state.

Verification: 85 offline tests passed, Ruff check and format passed, the PITWALL build passed, and browser smoke passed 136 AGENTS and 373 DATA checks. The real Lusail 2025 no-LLM replay displayed "routed, no RAG result" under Safety Car without crashing. Astra high returned GO.

Refs #1251

@coderabbitai

coderabbitai Bot commented Sep 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: a95f98c5-37c7-48ab-bedb-58744d1de726

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added area: codebase Touches src/, scripts/, or notebooks/ area: tests Touches tests/ labels Sep 23, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-23T20:14:30.361906Z a9f9a4d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@VforVitorio
VforVitorio merged commit 156efad into dev Sep 23, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: codebase Touches src/, scripts/, or notebooks/ area: tests Touches tests/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant