test(pitwall): trace real DATA and AGENTS path - #1256
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
area: codebase
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c837048ef3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| }, | ||
| "checks": { | ||
| "wire_decision_lap": true, |
There was a problem hiding this comment.
When this committed audit is treated as evidence for the new trace path, it could not have been produced by the submitted trace_pitwall_real_path.py: _evaluate_trace_checks now emits keys such as wire_seq_valid, host_seq_matches_wire, and data_live_matches_wire, while this report contains the older, weaker check set beginning with wire_decision_lap. The browser report is likewise from an older schema, storing screenshot strings where the submitted probe always stores {path, ok, size} objects. Consequently, the claimed real run does not exercise the capture implementation being added; regenerate all audit artifacts with the final scripts before using the PASS result.
Useful? React with 👍 / 👎.
| "data": "C:\\Users\\victo\\Desktop\\Documents\\Cuarto Año\\TFG\\F1_StratLab_1252\\documents\\audits\\TRACE_1252_1252-lusail-nor-l7-20260924-run1_data.png", | ||
| "agents": "C:\\Users\\victo\\Desktop\\Documents\\Cuarto Año\\TFG\\F1_StratLab_1252\\documents\\audits\\TRACE_1252_1252-lusail-nor-l7-20260924-run1_agents.png" |
There was a problem hiding this comment.
When the checked-in audit is verified from any checkout other than the author's Windows directory, verify_pitwall_trace.py interprets this absolute path verbatim, cannot find the committed PNG beside the report, and fails screenshots_exist_and_are_nonempty. Running the documented verifier against these artifacts in this checkout reproduces that failure. Store a repository-relative path or resolve the screenshot basename relative to the audit directory so the supplied evidence remains independently verifiable.
Useful? React with 👍 / 👎.
1 participant
Implements the real TCP-to-PITWALL trace for issue #1252. It captures and cross-validates the wire payload, host APIs, browser state, rendered DATA/AGENTS values, screenshots, sequence, race, action, and no-LLM mode. Adds a loopback port override, regression/mutant tests, and testing docs.\n\nValidated against the real 2025 Lusail NOR/McLaren Arcade run (lap 7, seq 3227): strict report PASS, 11 checks, 0 failures; both rendered views captured with no browser console errors. Focused tests: 156 passed; Ruff, format, Node syntax, UI build, and smoke checks passed.\n\nRefs #1252.