Skip to content

docs(diagrams): refresh strategy and PITWALL diagrams - #1258

Merged
VforVitorio merged 4 commits into
devfrom
docs/1253-diagram-fidelity
Sep 27, 2026
Merged

VforVitorio merged 4 commits into
devfrom
docs/1253-diagram-fidelity

Conversation

@VforVitorio

@VforVitorio VforVitorio commented Sep 27, 2026 •

Copy link
Copy Markdown
Owner

What

  • Restore the detailed editable diagrams and align their strategy, agent-schema, and PITWALL paths with the current implementation.
  • Update the multi-agent reference and diagram fidelity notes.
  • Audit scripts/ for dead or low-value measurement files. No safe deletions were identified.

Why

The previous diagrams described stale data contracts, scoring semantics, and PITWALL transport behavior. This refresh preserves the full engineering detail while correcting those contracts.

Scripts audit

  • Inventory: 53 files (48 Python), including 12 measure_*.py scripts.
  • Removed: 0 files, 0 lines. The measurement scripts are tied to current issues, reports, tests, reproducibility, or distinct diagnostics. Two small duplicated helpers were retained because the scripts serve separate reproducibility/trace workflows.

Validation

  • uv run pytest -q tests/surfaces/test_diagrams_no_retired_surface.py: 20 passed.
  • All six changed Draw.io sources parse with zero dangling edges.
  • Visible text matches across all three HTML/SVG export pairs.
  • The published strategy pipeline was opened in diagrams.net; a-n29-r is routed around N27 and enters the router from the side. The orchestrator HTML render also confirms the fallback fits its card.
  • Independent Astra gate: D1-D8 GO for diagram commit 11ea8aa.
  • Browser console and a new full render of every export were not captured in the final gate; no claim is made about those checks.
  • git diff --check: clean.

Related: #1253

Update routing, agent outputs, retrieval fallbacks, and PITWALL polling details. Refresh three 16:9 HTML/SVG pairs and record the fidelity ledger.

Checks: 20 diagram-surface tests passed. Six changed Draw.io sources parse without dangling edges. Chromium rendered the HTML and standalone SVG exports at 1280x720 with no console errors or text overflow.
@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: ead32a8a-aae1-4beb-bf8e-2ae84903b1f5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the area: docs Touches docs/, README, or other markdown label Sep 27, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-27T16:59:13.095261Z 881df7f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 881df7fe92

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

<p class="eyebrow">F1 StratLab · decision pipeline</p>
<svg viewBox="0 0 1280 720" xmlns="http://www.w3.org/2000/svg" role="img" aria-labelledby="orchestration-title orchestration-desc">
<title id="orchestration-title">N31 orchestrator flow</title>
<desc id="orchestration-desc">N25 to N28 distributions feed Monte Carlo, while N29 radio reasoning and N30 regulation evidence inform rich synthesis.</desc>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Show all agent inputs to rich synthesis

The rich pipeline does not split inputs this way: _build_orchestrator_prompt serializes the N25 pace, N26 tyre, N27 situation, and N28 pit blocks—including their reasoning—directly into SUB-AGENT OUTPUTS, in addition to supplying the Monte Carlo scores. This new description and the matching flow imply that N25–N28 affect synthesis only through Monte Carlo, which is particularly misleading for N25 because its sampled pace is currently unused by the scorer. Add a direct N25–N28 input to synthesis or revise the description and corresponding diagram/export.

Useful? React with 👍 / 👎.

@VforVitorio
VforVitorio merged commit 20d89f6 into dev Sep 27, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: docs Touches docs/, README, or other markdown

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant