Repository navigation
[interpreter/spec] Fix a couple of UTF-8 issues - #2295
Merged
Merged
Conversation
tlively
reviewed
Oct 21, 2026
| 0xc0 lor (n lsr 6) :: con n :: encode' ns | ||
| | n::ns when n >= 0xd800 && n < 0xe000 -> | ||
| raise Utf8 | ||
| | n::ns when n < 0x10000 -> |
Member
There was a problem hiding this comment.
This looks like a duplicate of the next case.
| @@ -37,7 +37,10 @@ let string s = | |||
| let j = !i + 2 in | |||
| i := String.index_from s j '}'; | |||
| let n = int_of_string ("0x" ^ String.sub s j (!i - j)) in | |||
Member
There was a problem hiding this comment.
Gemini tells me this will raise Failure "int_of_string" for overly long hex sequences, e.g. \u{ffffffffffff}.
| (assert_malformed | ||
| (module quote "(func (export \"\\u{D800}\"))") | ||
| "malformed UTF-8 codepoint" | ||
| ) |
Member
There was a problem hiding this comment.
It would be good to add a negative test for \u{DFFF} and a positive test for \u{E000} as well. Might as well do \u{D7FF} as well.
Member
Author
|
Done, PTAL. |
tlively
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2284 and fixes #2287.