builder: fix objdiff unit name for all-digit segments - #158
Merged
Conversation
A name made only of digits, like main's 17238, decodes from YAML as a number, so the string assertion failed and the unit fell back to its hex offset 7A38. make report then looked for a file that never existed.
eduardovra
marked this pull request as ready for review
September 11, 2026 03:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
[0x7A38, c, 17238]YAML parses17238as a number, so thesrc[2].(string)assertion fails and the name falls back to the hexoffset. Now accepts a number too.
We could just wrap those numbers in quotes, but I thought this would be a more definitive solution. Feel free to close it if you disagree.