feat(msgs): rcl_interfaces logger-level messages (hu stack 2/9)#233
Open
YuanYuYuan wants to merge 1 commit into
Open
feat(msgs): rcl_interfaces logger-level messages (hu stack 2/9)#233YuanYuYuan wants to merge 1 commit into
YuanYuYuan wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds ROS 2 rcl_interfaces logger-level message/service definitions to the in-tree codegen asset bundle (Jazzy), and updates hiroz-msgs’ build script so code generation is re-triggered when those external IDL assets change. This supports the staged rollout of logging support in the hu stack by landing the generated types ahead of their first consumer.
Changes:
- Add
rcl_interfacesLoggerLevel/SetLoggerLevelsResultmessages undercrates/hiroz-codegen/assets/jazzy/. - Add
rcl_interfacesGetLoggerLevels/SetLoggerLevelsservices undercrates/hiroz-codegen/assets/jazzy/. - Update
crates/hiroz-msgs/build.rsto rerun codegen when the codegen asset tree changes.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| crates/hiroz-msgs/build.rs | Adds explicit Cargo rerun tracking for codegen assets so message/service codegen re-runs when external IDL definitions change. |
| crates/hiroz-codegen/assets/jazzy/rcl_interfaces/srv/SetLoggerLevels.srv | Introduces the Jazzy SetLoggerLevels service definition. |
| crates/hiroz-codegen/assets/jazzy/rcl_interfaces/srv/GetLoggerLevels.srv | Introduces the Jazzy GetLoggerLevels service definition. |
| crates/hiroz-codegen/assets/jazzy/rcl_interfaces/msg/SetLoggerLevelsResult.msg | Adds the result message used by SetLoggerLevels. |
| crates/hiroz-codegen/assets/jazzy/rcl_interfaces/msg/LoggerLevel.msg | Adds the logger-level message used by both services. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
YuanYuYuan
force-pushed
the
dev/pr-hu-1b-logger-msgs
branch
from
July 24, 2026 23:39
bd63c02 to
5a43164
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
crates/hiroz-msgs/build.rs:18
cargo:rerun-if-changedon theassetsdirectory won’t reliably rerun the build script when an existing.msg/.srvfile is edited (directory mtime typically changes on add/remove, not on file content edits), and it also won’t catch changes under nested subdirectories unless those directories themselves are tracked. To actually make codegen rerun on definition edits/additions, emit rerun directives for the whole tree (dirs + files).
let manifest_dir = PathBuf::from(env::var("CARGO_MANIFEST_DIR")?);
if let Some(codegen_assets) = manifest_dir
.parent()
.map(|p| p.join("hiroz-codegen/assets"))
&& codegen_assets.exists()
YuanYuYuan
force-pushed
the
dev/pr-hu-1b-logger-msgs
branch
from
July 25, 2026 00:03
5a43164 to
d32b884
Compare
YuanYuYuan
force-pushed
the
dev/pr-hu-1b-logger-msgs
branch
from
July 25, 2026 13:04
d32b884 to
060a4cc
Compare
Adds the LoggerLevel and SetLoggerLevelsResult messages and the GetLoggerLevels and SetLoggerLevels services under hiroz-codegen assets, and makes hiroz-msgs' build.rs track the codegen asset tree so codegen re-runs when .msg/.srv definitions change. The generated types are not yet consumed by any code — they land ahead of the logging support that uses them.
YuanYuYuan
force-pushed
the
dev/pr-hu-1b-logger-msgs
branch
from
July 25, 2026 13:28
060a4cc to
65d9f50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked PR 2 of 9 splitting the
hu(hiroz-union) skeleton (#231). Adds thercl_interfacesLoggerLevel / SetLoggerLevelsResult messages and GetLoggerLevels / SetLoggerLevels services under hiroz-codegen assets, and makes hiroz-msgs' build.rs track the codegen asset tree so codegen re-runs when definitions change.The generated types are not yet consumed by any code — they land ahead of the logging support that uses them.
Base:
dev/pr-hu-1a-nix(PR #232). Breaking changes: none.