Conversation
size-limit report 📦
|
Member
|
This seems like a useful change, but I'm not sure it makes The issue I ran into is that |
Member
Author
|
You're correct. But it should work with this new method I'm prototyping. If you're happy to merge I'll test it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this might be a good way to handle local dev with Vite which supports only script type="module". Any objections to adding this capability here? I was building my own thing that pretty much did the same thing except with a ?proxy=https://localhost query string. But this is already built and it works.
I guess we would update the readme too to tell people how to do it like:
proxy('project-name', { type: "module"}).then(init);