Make email templates runtime-configurable#34
Merged
Merged
Conversation
Verification, password reset, and invitation emails now render from a single .tmpl file each (Subject + optional Content-Type + body, using minijinja) instead of hardcoded strings duplicated across three call sites. Every template ships a built-in default baked into the image; setting ATOM_EMAIL_TEMPLATES_DIR (Compose wires this to a bind mount) lets an operator override any subset without rebuilding, since Atom is embedded by multiple platforms/projects that each need their own branding.
ATOM_EMAIL_TEMPLATES_HOST_DIR/ATOM_EMAIL_TEMPLATES_DIR had no entry here, unlike the analogous ATOM_CERTS_CA_DIR pattern.
dborovcanin
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.tmplfile each (Subject:+ optionalContent-Type:+ body, minijinja{{ variable }}syntax) instead of hardcoded strings duplicated acrossidentity/service.rsandtenants/email.rs./app/email-templates; settingATOM_EMAIL_TEMPLATES_DIR(Compose wires this to a bind mount, defaulting to./email-templates) lets an operator override any subset at runtime, without rebuilding — useful since Atom is embedded by multiple platforms/projects that each need their own branding.Content-Type: text/htmlis optional per template (defaults totext/plain), so overrides can be full branded HTML.src/mail.rs.Test plan
cargo test --lib(126 passed)cargo fmt --check/cargo clippy --lib -- -D warningscleandocker build --target releasesucceeds and/app/email-templatescontains the three defaultsdocker-compose.local-build.yml, mounted branded HTML overrides viaATOM_EMAIL_TEMPLATES_HOST_DIR, confirmed the templates land readable inside the running container