fix(compose): stop creating config.toml as a directory - #260
Open
floze-the-genius wants to merge 1 commit into
Open
fix(compose): stop creating config.toml as a directory#260floze-the-genius wants to merge 1 commit into
floze-the-genius wants to merge 1 commit into
Conversation
Prevent Docker Compose from creating docker/config.toml as a directory when the provisioned file is missing. Preserve all three existing bind targets while disabling automatic host-path creation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Closes #258.
The provision wizard writes
docker/config.tomlas a regular file, but the Propeller Compose file used short bind-mount syntax for that path. If Compose is started before provisioning, Docker creates a missing bind source as a directory. The wizard then cannot replace that directory with the generated TOML file and reportsfailed to create docker/config.toml file.This converts all three config mounts (manager, proplet, and proxy) to long bind syntax with
bind.create_host_path: false.Compose will now fail clearly when the provisioned config is missing instead of mutating the host path into a directory. Existing mount targets and runtime behavior are unchanged once the file exists.
Users who already have an empty
docker/config.toml/directory still need to remove it once before running the provision command; Compose will not recreate it afterward.Verification
docker/compose.propeller.yamlwith Docker Compose v5.1.2.bind.create_host_path == false.go test ./...successfully.git diff --checksuccessfully.