fix(ssl): create certificate output directory - #261
Open
floze-the-genius wants to merge 1 commit into
Open
Conversation
Make CA generation create CRT_LOCATION idempotently before OpenSSL writes certificate files. This fixes both direct docker/ssl targets and the root check-certs flow on a fresh clone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Closes #257.
A fresh clone does not contain
docker/ssl/certs, so both direct CA generation and the rootcheck-certsprerequisite fail when OpenSSL tries to writecerts/ca.key.This adds an idempotent
$(CRT_LOCATION)directory target and makescadepend on it as an order-only prerequisite. Existing certificate directories are left untouched, and the directory timestamp does not force CA regeneration.Verification
make -C docker/ssl cafailing withCan't open "certs/ca.key" for writingbefore the change.make check-certsfailing for the same reason before the change.CRT_LOCATIONand creates the directory,ca.crt, andca.key.make check-certscreates CA and server certificates successfully.mkdirrecipe.go test ./...git diff --checkDisposable certificates were generated only under
/tmp; repository and user certificate paths were not modified.