Revert validation of album artists separator - #998
Merged
Conversation
chvp
approved these changes
Aug 29, 2026
This reverts a small part of #722, where I moved the separator to the album artist model. This worked inside the model tests, but does not work in the controller since when updating (since we fully replace the album artists, during the validation `album.album_artists.size` is 0.
robbevp
force-pushed
the
fix/separator-validations
branch
from
August 29, 2026 15:05
ac58e48 to
adfc3ec
Compare
robbevp
enabled auto-merge
August 29, 2026 15:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts a small part of #722, where I moved the separator to the album artist model. This worked inside the model tests, but does not work in the controller since when updating (since we fully replace the album artists, during the validation
album.album_artists.sizeis 0.There are still two underlying issues that are not solved here:
ActiveRecord::RecordNotSavederror and not render a body in the form that we expect. (I suspect this is the case for all associations that get replaced in our controllers: album labels, track artists, ...){ model: 'album', attribute: 'album_artists', type: 'invalid' }. So we have no context about which of the album artists is invalid and just what the issue is.I suspect that both of these issues where already present before Return errors as json objects instead of strings #722 - they are a bit trickier to solve, so I already wanted to get this quick fix out