Render useful errors when album artists are invalid - #999
Draft
robbevp wants to merge 2 commits into
Draft
Conversation
robbevp
force-pushed
the
fix/separator-validations
branch
from
August 29, 2026 15:05
ac58e48 to
adfc3ec
Compare
robbevp
force-pushed
the
enhc/album-artists-errors-response
branch
from
August 30, 2026 08:28
fca2bd5 to
61d1ddf
Compare
Member
Author
|
@chvp I added a POC for how we could fix this situation: if we use Two other options I see:
I think I have a preference for the last option, our web client already handles a bunch of logic when editing data so it feels more at home there than in the controllers. This also means that requests could be more granular and actually update one album_artist at a time, without needing to resend all the other data |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1000
Draft PR with a failing test - I'll pick this up later again