[login] Add dropdown translation in login summary statistics - #11012
[login] Add dropdown translation in login summary statistics#11012HachemJ wants to merge 3 commits into
Conversation
|
@skarya22 can you review this? |
| msgid "EEG Recording" | ||
| msgid_plural "EEG Recordings" | ||
| msgstr[0] "" | ||
|
|
||
| msgid "Female Participant" | ||
| msgid_plural "Female Participants" | ||
| msgstr[0] "" | ||
|
|
||
| msgid "Instrument" | ||
| msgid_plural "Instruments" | ||
| msgstr[0] "" | ||
|
|
||
| msgid "Male Participant" | ||
| msgid_plural "Male Participants" | ||
| msgstr[0] "" | ||
|
|
||
| msgid "Scan" | ||
| msgid_plural "Scans" | ||
| msgstr[0] "" | ||
|
|
||
| msgid "Site" | ||
| msgid_plural "Sites" | ||
| msgstr[0] "" | ||
|
|
||
| msgid "Visit" | ||
| msgid_plural "Visits" | ||
| msgstr[0] "" | ||
|
|
There was a problem hiding this comment.
I am realizing that these fields are added through SQL queries at /SQL/Login_Summary_Statistics, and can be overwritten by projects through the project/tools/Login_Summary_Statistics folder.
However, if a project adds queries, to translate them, they would have to override this file in the project folder, causing them to have to copy the whole login module to the project.
Instead, we should move the translations to SQL like in #10513
Let me know if this makes sense -- since these fields are technically generated through SQL I think their translations should be too so that projects can override them easily.
There was a problem hiding this comment.
@skarya22 You don't need to override the whole module to update the translation strings. project/locale/ takes precedent over the module.
There was a problem hiding this comment.
Ah I see, then @HachemJ we can leave it as is! This would be easier then
Brief summary of changes
This PR translates the project dropdown in the Login Summary Statistics page and the CSV text copied to the clipboard when using the export button.
Testing instructions (if applicable)
project/localeraisinbread/localeintoproject/localemake dev(make sure it ran the msgfmt --use-fuzzy -o table.mo table.po commands)Link(s) to related issue(s)