[dataquery] Add toggle to hide candidates with no data - #11017
Open
HenriRabalais wants to merge 1 commit into
Open
[dataquery] Add toggle to hide candidates with no data#11017HenriRabalais wants to merge 1 commit into
HenriRabalais wants to merge 1 commit into
Conversation
Co-authored-by: arnav-makkar <arnav-makkar@users.noreply.github.com>
Collaborator
Author
|
Also verified on the instrument path, which is what the original report in #9837 was using. Query: PSCID + |
Contributor
|
Thanks for picking this up, @HenriRabalais |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The beta DQT queries the
candidatetable first and then joins the data, so candidates with no data for the selected fields still come back as rows with just their metadata (PSCID and empty columns). The old CouchDB DQT excluded them naturally because the document simply did not exist.As discussed in #9837, the decision was to keep returning all rows from the API and add a UI toggle to hide the empty ones, so a coordinator doing quality control can still see every participant while a researcher can filter them out without adding filters.
This carries over the work from #10348 by @arnav-makkar, who is no longer working on LORIS. The filtering logic is his, with a reworded label and the translations added.
Changes
Testing Instructions
t1_filefield.Note that a field like
ScanDoneis not a good test here, since it is computed asEXISTS(files) OR EXISTS(mri_upload) OR EXISTS(tarchive)and returns a realfalsefor any session that exists. It displays as "(No data)" but it is data, so those rows are correctly kept.Related Issues
Resolves #9837
Replaces #10348