Skip to content

[imaging_uploader] Add missing translations for pop up and error messages - #11074

Merged
driusan merged 5 commits into
aces:29.0-releasefrom
HachemJ:FixUntranslatedPopUpAndErrorMessages
Aug 4, 2026
Merged

[imaging_uploader] Add missing translations for pop up and error messages#11074
driusan merged 5 commits into
aces:29.0-releasefrom
HachemJ:FixUntranslatedPopUpAndErrorMessages

Conversation

@HachemJ

@HachemJ HachemJ commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Brief summary of changes

This PR adds missing pop up and error messages translations in French in the imaging_uploader module.

Note: This PR also includes the translation of another error message in the same file.

Testing instructions (if applicable)

  1. Go to 'Imaging' -> 'Imaging Uploader'
  2. Go to the 'Upload' tab
  3. Switch the language to French
  4. Fill the Upload form (an example is shown below)
image
  1. Click on 'Soumettre'
  2. Observe the translated pop up and error messages in French
Telliverser un scan d'age

Note: run sudo systemctl restart apache2 if the translation doesn't show up.
Reason: #10933 (comment)

Link(s) to related issue(s)

@github-actions github-actions Bot added Language: PHP PR or issue that update PHP code Module: imaging_uploader PR or issue related to imaging_uploader module Multilingual Any tasks related to making LORIS multilingual labels Jul 28, 2026
@HachemJ HachemJ added the 29.0.0 - Bugs Issues found during the release testing for 29.0.0 label Jul 28, 2026
@lapadulamichael
lapadulamichael self-requested a review August 3, 2026 17:34
@lapadulamichael lapadulamichael self-assigned this Aug 3, 2026
@lapadulamichael

Copy link
Copy Markdown
Contributor

@HachemJ
Some error messages still need translations :
image

@HachemJ

HachemJ commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

@HachemJ Some error messages still need translations : image

Done.

Comment thread modules/imaging_uploader/php/imaging_uploader.class.inc
@lapadulamichael
lapadulamichael self-requested a review August 3, 2026 20:39
Comment thread modules/imaging_uploader/php/imaging_uploader.class.inc Outdated
@lapadulamichael

Copy link
Copy Markdown
Contributor

These are missing a space which causes those translations to not work. Otherwise the PR works well

@HachemJ
HachemJ force-pushed the FixUntranslatedPopUpAndErrorMessages branch from 99068a4 to 2837e1c Compare August 4, 2026 13:21
@HachemJ
HachemJ requested a review from lapadulamichael August 4, 2026 13:23
@HachemJ

HachemJ commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

These are missing a space which causes those translations to not work. Otherwise the PR works well

Done.

@lapadulamichael lapadulamichael left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lapadulamichael lapadulamichael added the Passed manual tests PR has been successfully tested by at least one peer label Aug 4, 2026
@driusan
driusan merged commit 6096bde into aces:29.0-release Aug 4, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

29.0.0 - Bugs Issues found during the release testing for 29.0.0 Language: PHP PR or issue that update PHP code Module: imaging_uploader PR or issue related to imaging_uploader module Multilingual Any tasks related to making LORIS multilingual Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants