[login] Adding reset password email translations

[lapadulamichael]

Brief summary of changes

• Added the translations for lost_password.tpl
• Fixed bug where entering new generated password always returned "Expired password" message

Priority High given the bug blocks users from entering their new generated password successfully.

Testing instructions (if applicable)

1. Setup your environment to receive emails
2. Go to login
3. Change the language
4. Click on reset password
5. Ensure you got the email and that it is translated
6. Ensure that the new generaed password works in login

Link(s) to related issue(s)

• Resolves 11075 (Reference the issue this fixes, if any.)

[HachemJ]

Could you not use dgettext() in lost_password.tpl, perhaps with the login domain? Since the template is outside the modules, I'm not sure if that will work. Jefferson brought up the same exact issue you're fixing in this PR while reviewing my password reset rework changes (not going in 29.0.0 because too late), so I was wondering if this approach had been considered. I haven’t tried it myself, but I know dgettext() can be used in .tpl files, and it would avoid having multiple versions of the same file.

[driusan]

I think this way makes more sense to me because you want to translate the whole email as a unit, and might want to move things around. Using dgettext in individual sections of the template would mean that you can only translate them piecemeal.

The downside of doing it this way is that you can't override a language translation without overriding the module that has the template, but overall I think this approach is better than hacking up templates with dgettext for emails.

[HachemJ]

I think this way makes more sense to me because you want to translate the whole email as a unit, and might want to move things around. Using dgettext in individual sections of the template would mean that you can only translate them piecemeal.

The downside of doing it this way is that you can't override a language translation without overriding the module that has the template, but overall I think this approach is better than hacking up templates with dgettext for emails.

That makes sense. My initial thought was something like this. It’s definitely less elegant, but it keeps everything in one block. I kind of used that approach in the statistics module when I was dealing with template files.

{sprintf(
dgettext(
'login',
"Subject: Lost Password - %s\n\n%s,\nYour password....."
),
$study,
$realname,
...

[HachemJ]

I'm okay with both I will just adapt whenever I have to resolve the conflicts on my PR for the rework of the reset password functionality (where I modified this specific template file).

[HachemJ]

I followed the testing instructions in all 6 languages. I got no errors during the process and I was able to reset my password successfully 6 times.

One thing to note is that the 'LORIS Demonstration Database' string (which is the study name) is not translated in neither spanish, chinese nor hindi.

This is because the table (ConfigI18n) which holds the db translations for the study name doesn't have the translations in any of these 3 languages mentioned above.

If you were to fix it in the same PR, the workflow should be the following:

• Source a fresh database using make testdata.
• Translate 'LORIS Demonstration Database' into these three languages, then insert the translations directly into the database using mysql.
• Once you’re done, run tools/exporters/DB_dump_table_data.php to export the updated table data.
  then git add raisinbread/RB_files/RB_ConfigI18n.sql

If you see many other files after running the script, it’s likely because earlier changes didn’t follow the procedure described in the raisinbread README.md

In short: it is not recommended to manually edit the Raisinbread SQL/data files. However, if you were to make the exact same changes, the end result is generally the same. But the exporter is mainly there to ensure the files accurately reflect the database state and are generated in the expected format.

[lapadulamichael]

Added only Chinese and Hindi translations since Spanish is not in RB yet

[HachemJ]

Added only Chinese and Hindi translations since Spanish is not in RB yet

Received the emails with the translated study names and successfully reset my password twice.

[HachemJ]

LGTM