Skip to content

[survey_accounts] Translate to Japanese and clean up translation code - #11098

Open
driusan wants to merge 3 commits into
aces:29.0-releasefrom
driusan:SurveyAccountsJa
Open

[survey_accounts] Translate to Japanese and clean up translation code#11098
driusan wants to merge 3 commits into
aces:29.0-releasefrom
driusan:SurveyAccountsJa

Conversation

@driusan

@driusan driusan commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

This translates the survey_accounts module into Japanese, and in doing so cleans up some portions of the translation code.

  1. Close, Email, and Status all exist in the loris namespace, so use those instead of duplicating the translations in the module
  2. There was an extra apostrophe in one of the English strings.
  3. "already exists for given candidate for visit" was a partial string using string concatenation to add variables, so use an interpolated sprintf string
  4. "does not exist for given candidate" was a string concatenation, but the only variable being concatenated was the translation of "Visit" from the loris namespace. So just include "Visit" in the whole string to make it easier to translate the sentence as a whole.
  5. While updating the French to match the new template strings, I found "le candidat donné" for "the given candidate" to be an awkward literal translation, so I changed it to "le candidat spécifié". (I can revert this if French speakers disagree.)

@driusan driusan added the 29.0.0 - Bugs Issues found during the release testing for 29.0.0 label Jul 29, 2026
@github-actions github-actions Bot added Language: PHP PR or issue that update PHP code Language: Javascript PR or issue that update Javascript code Module: survey_accounts PR or issue related to the survey_accounts module Multilingual Any tasks related to making LORIS multilingual labels Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

29.0.0 - Bugs Issues found during the release testing for 29.0.0 Language: Javascript PR or issue that update Javascript code Language: PHP PR or issue that update PHP code Module: survey_accounts PR or issue related to the survey_accounts module Multilingual Any tasks related to making LORIS multilingual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant