Skip to content

Add exempt-issue-types option for blocklist filter by issue type - #1294

Merged
v-HarithaVattikuti merged 5 commits into
actions:mainfrom
veryfancy:exempt-issue-types
Sep 10, 2026
Merged

v-HarithaVattikuti merged 5 commits into
actions:mainfrom
veryfancy:exempt-issue-types

Conversation

@veryfancy

@veryfancy veryfancy commented Oct 3, 2025 •

Copy link
Copy Markdown
Contributor

Description:

Introduce a parameter exempt-issue-types that ensures that issues from a list of types will not be marked stale or closed. This option applies only to issues; pull requests are always ignored by the issue-type filter.

This is a blocklist counterpart to the allowlist option only-issue-types added in:

Related issue:

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@veryfancy
veryfancy requested a review from a team as a code owner October 3, 2025 21:52
Copilot AI review requested due to automatic review settings October 3, 2025 21:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@maxwxyz

maxwxyz commented Oct 4, 2025

Copy link
Copy Markdown

@luketomlinson this is similar to #1255

@Bibo-Joshi Bibo-Joshi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. As a heads-up, I see that main.ts was not updated, which will probably lead to the input being ignored. See #1298, were I discovered that for only-issue-types :)

@veryfancy
veryfancy requested a review from Bibo-Joshi October 15, 2025 22:12
@veryfancy

Copy link
Copy Markdown
Contributor Author

@Bibo-Joshi Thank you for the heads-up. I updated main.ts to include input reading for exemptIssueTypes. I included onlyIssueTypes as well, in case this merges first (and because I suspect it might prevent a merge conflict if your PR merges first).

@Bibo-Joshi Bibo-Joshi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet :)

@moritzheiber

Copy link
Copy Markdown

@veryfancy heads-up, #1298 was just merged, so this will need conflict resolution

@veryfancy

Copy link
Copy Markdown
Contributor Author

Resolved conflicts. 🚀

@veryfancy

Copy link
Copy Markdown
Contributor Author

Bump to this. 🙏

1 similar comment
@veryfancy

Copy link
Copy Markdown
Contributor Author

Bump to this. 🙏

@laureanobrs

Copy link
Copy Markdown

Bump. Currently, there’s no way to process untyped issues together with only certain typed issues. This feature would make that possible. 🙏

@TNATALI

TNATALI commented Aug 25, 2026

Copy link
Copy Markdown

Bump this ya'll. Literally we are waiting on this PR to be merged and available. Would do a ton of good for the community.

@veryfancy

Copy link
Copy Markdown
Contributor Author

Fixed conflict with dist.js and updated behavior to keep it from filtering pull requests (to match the fix from #1338).

@v-chiranjib-swain

Copy link
Copy Markdown
Contributor

@veryfancy , thanks for this update. I tested the branch locally and with real Issue Types, including its interaction with only-issue-types, and it works as expected.

Could we document that exempt-issue-types takes precedence when both lists contain the same type and add a regression test for that case? This would make the behavior clear and prevent future regressions.

@veryfancy

Copy link
Copy Markdown
Contributor Author

@v-chiranjib-swain Thanks for testing this. I documented the precedence and added a regression test covering a type present in both lists.

@v-HarithaVattikuti
v-HarithaVattikuti merged commit f01e4de into actions:main Sep 10, 2026
5 of 8 checks passed
@veryfancy
veryfancy deleted the exempt-issue-types branch September 11, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants