Repository navigation
Update examples - #26
Merged
Merged
Conversation
Contributor
|
rfm_fixed_length_receive.py now defaults to CE1/D25, which fails on the Feather RP2040 RFM (no board.CE1). Intentional? Also typos: "pakets" in both fsk_node files, "fornatted" in listen_ack. |
Collaborator
Author
|
The pin choices are kind of arbitrary. The user really needs to adjust them as needed. CE1/D25 is for the "bonnet" on a Raspberry Pi which was what I used last. Would you prefer they were all standardized to RFM_CS/RST ? |
Contributor
|
Looks good. Not from this PR, but most examples here default to Pi pins (CE1/D25), unlike RFM9x/RFM69 where simpletest was Feather and Pi had its own file. |
mikeysklar
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #25
Update comments in several examples to remove incorrect or confusing information.
Remove a few lines of unnecessary code in some examples.
No functional changes.
Tested on RFM95 bonnets connected to Raspberry Pis.