Conversation
Move da-live's non-UI AEM Assets logic into Nexter so canvas, the classic editor, and the SC editor share one implementation. It covers repository config, URL building, a selection resolver with approval and publish checks, and a memoized loader for Adobe's hosted selector. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Require confirmation before clearing an image field. Keep the asset file untouched, remove the obsolete Undo toast, and restore focus after Cancel or Remove. Align the Replace button hover surface with its rounded shape. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Render string fields with the media semantic type as an image field. The stored URL stays unchanged. Offer Upload on every site and AEM Assets only when the site config names a repository and the host provides a picker. Log into the DA preview and content origins so private images preview. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Open Adobe's hosted AEM Assets selector from the image field when the site configures aem.repositoryId. The shared resolver turns the pick into the same URL canvas inserts, and errors keep the previous value. The selector code loads only when the user picks AEM Assets. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Add the media semantic type from da-sc-sdk#18 to the bundled SDK so image fields render. The bundle is hand-patched and does not match the 0.5.0 dependency yet. Rebuild it with npm run build:da-sc-sdk after the SDK release and the version bump. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This was referenced Oct 1, 2026
The preview area painted a decorative gradient that flashed while an uploaded image loaded and showed through transparent pixels. Use a neutral surface, reveal the image once it has loaded, and draw the canvas transparency checkerboard behind it. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #799 and the release of adobe/da-sc-sdk#18. Until #799 merges, the SDK is released and the bundle is rebuilt, this PR stays a draft.
What
Adds an image field to the Structured Content editor. Schema properties with
"x-semantic-type": "media"render as an image field instead of a text input. Authors can upload an image, pick one from AEM Assets, replace it, or remove it after a confirmation. The document stores a single URL string.AEM Assets appears only when the site config has
aem.repositoryId. It opens Adobe's hosted Asset Selector in a modal dialog and loads its code only when chosen. Rejected assets, failed uploads, and cancel all keep the previous value and show errors inline.The SDK bundle in
nx/deps/da-sc-sdkis hand-patched to expose themediasemantic type from adobe/da-sc-sdk#18. It will be rebuilt withnpm run build:da-sc-sdkafter the SDK release.Why
Structured content often needs images, and authors should not have to paste URLs by hand. The field follows the Spectrum style of the other form fields and reuses what DA already offers. Uploads use the existing
source.uploadMediaAPI. AEM Assets uses the shared module from #799, so the stored URL matches what canvas inserts.Not included