fix(loc): use Smartling file status instead of job percentComplete - #809
Draft
markdaugherty wants to merge 3 commits into
Draft
markdaugherty wants to merge 3 commits into
markdaugherty wants to merge 3 commits into
Conversation
Job-scoped percentComplete ignores unauthorized strings and reports null for locales it has no content for, so a locale could be marked translated and downloaded while strings were still untranslated. Poll per-file file/status and compute progress with Smartling's documented formula. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Re-check terminal status after file status requests return so a language that completed mid-flight is not overwritten, and skip overlapping status polls in handleGetStatus. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
file/statusper file instead of the job/progressendpoint.translatedonly when every file is at 100%; otherwise show the lowest per-file progress.progress: null→ 100% rule. A locale missing from the response counts as 0%.handleGetStatus.