Skip to content

Washing Machine Workflow Updates - #6535

Merged
najikahalsema merged 11 commits into
mainfrom
halsema/wm-bug-updates
Jul 22, 2026
Merged

Washing Machine Workflow Updates#6535
najikahalsema merged 11 commits into
mainfrom
halsema/wm-bug-updates

Conversation

@najikahalsema

@najikahalsema najikahalsema commented Jul 21, 2026

Copy link
Copy Markdown
Member

Description

  • Update the washing machine workflow documentation and the migration-prep skills and templates to account for the step of cataloguing, triaging, and closing existing bugs for the gen1 implementation of the component.
  • I've updated the Popover migration plan to serve as an example and test the skill's output. I also generated a migration plan for Overlay to validate the output when making a migration plan from scratch, but didn't commit it.
  • Also added an extra line re: VRTs in step 7.

My questions:

  • Are my additions to the skills in the appropriate places? Did I miss any locations?
  • Should any more specifics be added to the skills to help harden the reliability of the output?

Motivation and context

This PR updates our process to reflect the changes presented in the QDR regarding our triage/resolution policy for gen1 bugs.

Related issue(s)

image

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Review the Popover migration plan additions

    1. Go to the migraiton plan for popover
    2. Review that the gen1 open issues section includes a list of open issues in Jira that are related to popover
  • Use the skill to add a table to the migration plan (optional)

    1. Pull the branch to your local machine.
    2. In Claude Code, run the following prompt: "Update CONTRIBUTOR-DOCS/03_project-planning/03_components/[MIGRATED GEN2 COMPONENT OF YOUR CHOICE]/migration-plan.md so that it includes a section below "Dependencies" with a table of open gen1 issues. Use the migration prep skill to understand how to build the table."
    3. Review that the output of Claude includes the relevant issues in the appropriate section of the document
  • Validate the output (optional)

    1. Pull the branch to your local machine.
    2. Run the command "Create a migration plan for [component, eg Overlay, Dialog, etc]"
    3. Expect a migration plan to generate a markdown table that lists the open gen1 issues for the component in Jira.
    4. Expect that it doesn't add any superfluous text and prompts the user to review the generated output, highlighting certain bugs that Claude is uncertain about their inclusion or potentially duplicates.

@najikahalsema
najikahalsema requested a review from a team as a code owner July 21, 2026 17:53
@najikahalsema najikahalsema added the Status:WIP PR is a work in progress or draft label Jul 21, 2026
@changeset-bot

changeset-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c7d9529

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

📚 Branch Preview Links

🔍 Gen1 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-6535

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@coveralls

coveralls commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 29957680323

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage decreased (-0.002%) to 96.241%

Details

  • Coverage decreased (-0.002%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 39208
Covered Lines: 37935
Line Coverage: 96.75%
Relevant Branches: 6466
Covered Branches: 6022
Branch Coverage: 93.13%
Branches in Coverage %: Yes
Coverage Strength: 461.06 hits per line

💛 - Coveralls

@najikahalsema najikahalsema added Component:Documentation Issues or PRs involving changes to docs or docs website. Component prefix is for Jira integration. Status:Ready for review PR ready for review or re-review. skip_vrt Skip VRT build; mark UI Tests green without running Chromatic and removed Status:WIP PR is a work in progress or draft labels Jul 22, 2026
@najikahalsema
najikahalsema enabled auto-merge (squash) July 22, 2026 21:02
@najikahalsema
najikahalsema merged commit bc1d606 into main Jul 22, 2026
29 of 30 checks passed
@najikahalsema
najikahalsema deleted the halsema/wm-bug-updates branch July 22, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component:Documentation Issues or PRs involving changes to docs or docs website. Component prefix is for Jira integration. skip_vrt Skip VRT build; mark UI Tests green without running Chromatic Status:Ready for review PR ready for review or re-review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants