Skip to content

fix: nested .section fragment bug #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fkakatie merged 2 commits into from
Jun 27, 2026
Merged

fix: nested .section fragment bug #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84decb5
fix: convert fragment links to blocks synchronously before section de…
fkakatie Jun 27, 2026
8a2a297
fix: replace section or flatten blocks to prevent nested .section
fkakatie Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion blocks/fragment/fragment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,19 @@ export default async function decorate(block) {
const link = block.querySelector('a');
const path = link ? link.getAttribute('href') : block.textContent.trim();
const fragment = await loadFragment(path);
if (fragment) block.replaceChildren(...fragment.childNodes);
if (!fragment) return;

const wrapper = block.closest('.fragment-wrapper');
const section = wrapper.closest('.section');

if (section && section.children.length === 1) {
// fragment is the ONLY child of its section; replace the whole section
section.replaceWith(...fragment.childNodes);
} else {
// fragment shares section with other children; flatten blocks into it
fragment.querySelectorAll(':scope > .section').forEach((fragSection) => {
[...fragSection.childNodes].forEach((child) => wrapper.before(child));
});
wrapper.remove();
}
}
23 changes: 6 additions & 17 deletions scripts/scripts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,24 +153,13 @@ function buildVideoAutoBlocks(main) {
* @param {Element} main The container element
*/
function buildFragmentAutoBlocks(main) {
const fragments = [...main.querySelectorAll('a[href*="/fragments/"]')].filter((f) => !f.closest('.fragment'));
if (!fragments.length) return;
// hide containers immediately so raw links never flash before replacement
fragments.forEach((f) => { f.parentElement.style.visibility = 'hidden'; });
// eslint-disable-next-line import/no-cycle
import('../blocks/fragment/fragment.js').then(({ loadFragment }) => {
fragments.forEach(async (fragment) => {
try {
const { pathname } = new URL(fragment.href);
const frag = await loadFragment(pathname);
fragment.parentElement.replaceWith(...frag.children);
} catch (error) {
fragment.parentElement.style.visibility = '';
// eslint-disable-next-line no-console
console.error('Fragment loading failed', error);
}
[...main.querySelectorAll('a[href*="/fragments/"]')]
.filter((f) => !f.closest('.fragment'))
.forEach((link) => {
const fragmentBlock = buildBlock('fragment', { elems: [link.cloneNode(true)] });
const p = link.closest('p');
(p || link).replaceWith(fragmentBlock);
});
});
}

/**
Expand Down