Remove predicates that were specified twice in the initial state. - #18
Merged
Merged
Conversation
SimonDold
approved these changes
Jul 23, 2026
SimonDold
left a comment
SimonDold
left a comment
There was a problem hiding this comment.
I added to each removed line a comment to the line that had the duplicate which i tested with meld (mainly to prevent myself from skipping one).
In assembly/prob19.pddl the end of file changed in a weird way that probably means nothing.
I suggested a change for the README.md
But i am fine as is.
| (assemble-order frob foobar hack) | ||
| (assemble-order widget valve socket) | ||
| (assemble-order widget valve socket) | ||
| (assemble-order widget valve doodad) |
| (assemble-order sprocket hack gimcrack) | ||
| (assemble-order frob foobar hack) | ||
| (assemble-order widget valve socket) | ||
| (assemble-order widget valve socket) |
| (assemble-order connector-5 mount-7 kludge-4) | ||
| (remove-order mount-7 connector-5 kludge-4) | ||
| (assemble-order bracket device kludge-4) | ||
| (assemble-order bracket device kludge-4) |
| ;; (remove-order sprocket hack contraption) ;; BUG: sprocket not defined -- Malte | ||
| (assemble-order connector-5 mount-7 contraption) | ||
| (assemble-order bracket device fastener) | ||
| (assemble-order bracket device fastener) |
| (assemble-order fastener coil-7 mount) | ||
| (assemble-order fastener frob mount) | ||
| (assemble-order tube-6 unit-5 coil-7) | ||
| (assemble-order tube-6 unit-5 coil-7) |
| (assemble-order hoozawhatsie foobar bracket) | ||
| (assemble-order foobar gimcrack bracket) | ||
| (assemble-order foobar gimcrack bracket) | ||
| (assemble-order foobar gimcrack whatsis) |
| (assemble-order fastener sprocket unit) | ||
| (remove-order sprocket fastener unit) | ||
| (assemble-order connector foobar sprocket) | ||
| (assemble-order connector foobar sprocket) |
| (assemble-order connector foobar sprocket) | ||
| (assemble-order tube connector sprocket) | ||
| (assemble-order connector foobar fastener) | ||
| (assemble-order connector foobar fastener) |
| (at ap9 d1 BER) | ||
| (at ap9 d9 HAM) | ||
| (at ap10 d4 FRA) | ||
| (at ap10 d4 FRA) |
| initial state. | ||
|
|
||
| - **assembly**: We removed predicates that were specified twice in the initial | ||
| state. |
There was a problem hiding this comment.
These sentences have the same semantic. I would use both times the very same then, to reduce mental load.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.