rename ABC class to AbstractRemote to not be confused with abc.ABC#581
Open
Vizonex wants to merge 3 commits intoaio-libs:masterfrom
Open
rename ABC class to AbstractRemote to not be confused with abc.ABC#581Vizonex wants to merge 3 commits intoaio-libs:masterfrom
Vizonex wants to merge 3 commits intoaio-libs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
I decided to go through a repository I've never touched before and something that I thought was pretty weird was the wording for the
aiohttp_remotes.abcmodule. I decided to rename it because I didn't want to confuse developers even though this has been here for over 6 years. The one thing I try to do when I develop my own libraries or packages is not to confuse other developers.Are there changes in behavior for the user?
What I hope this change does is at least clarify what this class is and what it is meant for someone importing this normally and has no clue what it is without reading the code itself may not realize that this does not belong to
abc.ABCin the python library hence my change here. I would've thrown an issue about this but I had just decided to just write it in anyways since it was so tiny. I did make sure to poke around to see if this was talked about though and so far it just hasn't. Hopefully if this PR is blocked for whatever reason I'll know as to why the naming ofABCwas meant to be here at least.Feel free to let me know if the ABC name should just be deprecated if this PR goes forward.
Related issue number
Checklist