Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions scripts/performRelease/fetchCommitsSinceTag.ts
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
import type { GithubClient } from '../utils/getGitHubClient';
import getRepoContext from '../utils/getRepoContext';
import runGithubRequestWithRetries from './runGithubRequestWithRetries';

export default async function fetchCommitsSinceTag(client: GithubClient, tagSha: string) {
console.log('Fetching commits since sha', tagSha);

const { owner, repo } = getRepoContext();
return client.request('GET /repos/{owner}/{repo}/compare/{base}...{head}', {
owner,
repo,
base: tagSha,
head: 'HEAD',
});
return runGithubRequestWithRetries(`Fetch commits since ${tagSha}`, () =>
client.request('GET /repos/{owner}/{repo}/compare/{base}...{head}', {
owner,
repo,
base: tagSha,
head: 'HEAD',
}),
);
}
26 changes: 22 additions & 4 deletions scripts/performRelease/runGithubRequestWithRetries.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,27 @@ function getErrorMessage(error: unknown) {
}
}

function isRateLimitError(error: unknown) {
function getErrorStatus(error: unknown) {
const status =
typeof error === 'object' && error !== null && 'status' in error ? error.status : null;

return status === 429 || /rate limit|secondary limit/i.test(getErrorMessage(error));
return typeof status === 'number' ? status : null;
}

function isRetryableGitHubRequestError(error: unknown) {
const status = getErrorStatus(error);
const message = getErrorMessage(error);

return (
status === 429 ||
status === 500 ||
status === 502 ||
status === 503 ||
status === 504 ||
/rate limit|secondary limit|premature close|socket hang up|econnreset|etimedout|eai_again|fetch failed/i.test(
message,
)
);
}

export async function pauseBetweenGitHubRequests() {
Expand All @@ -44,12 +60,14 @@ export default async function runGithubRequestWithRetries<T>(
} catch (error) {
const delayMs = RETRY_DELAYS_MS[attempt];

if (!isRateLimitError(error) || delayMs === undefined) {
if (!isRetryableGitHubRequestError(error) || delayMs === undefined) {
throw error;
}

console.warn(
`${label} hit a GitHub rate limit. Retrying in ${delayMs / 1000}s: ${getErrorMessage(error)}`,
`${label} hit a retryable GitHub request error. Retrying in ${
delayMs / 1000
}s: ${getErrorMessage(error)}`,
);
await wait(delayMs);
return runGithubRequestWithRetries(label, request, attempt + 1);
Expand Down
Loading