Skip to content

Bump rust and alpine versions - #186

Merged
aleyan merged 4 commits into
mainfrom
docker
Aug 12, 2026
Merged

Bump rust and alpine versions#186
aleyan merged 4 commits into
mainfrom
docker

Conversation

@aleyan

@aleyan aleyan commented Aug 11, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Chores

    • Updated the minimum supported Rust version to 1.96.1 across the project.
    • Upgraded test environments to Alpine Linux 3.24.
    • Streamlined installation of the Task command in test environments.
    • Updated the unit test environment to use the project’s local builder image.
    • Improved automatic local builder image creation when needed.
  • Documentation

    • Updated Rust setup and testing documentation to reflect the new toolchain and Alpine versions.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 33c1a246-86c1-415e-80a3-8aa153a8d015

📥 Commits

Reviewing files that changed from the base of the PR and between 700c067 and b7e8987.

📒 Files selected for processing (4)
  • .github/workflows/release.yml
  • .github/workflows/rust.yml
  • README.md
  • tests/run_tests.sh

📝 Walkthrough

Walkthrough

The project now targets Rust 1.96.1 and Alpine 3.24. CI, release workflows, documentation, and test images use the updated versions. Docker test images install go-task from Alpine packages. The noinit image removes manual act installation.

Changes

Toolchain and test environment refresh

Layer / File(s) Summary
Rust toolchain alignment
Cargo.toml, rust-toolchain.toml, Makefile, README.md, .github/workflows/*.yml
Project configuration, workflows, and installation instructions now use Rust 1.96.1.
Builder image and test runner updates
tests/Dockerfile.builder, tests/docker_unit/Dockerfile, tests/run_tests.sh
The builder image uses Rust 1.96.1 and Alpine 3.24. The unit image uses dela-builder. The test runner builds the image when it is not configured or available locally.
Integration test image updates
tests/docker_*/Dockerfile, dev_docs/testing.md
Integration images use Alpine 3.24 and install go-task through Alpine packages. The noinit image removes manual act installation. Documentation reflects Alpine 3.24.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • aleyan/dela#156: Updates the same Rust toolchain and Docker configuration areas.
  • aleyan/dela#170: Updates the same pinned Rust toolchain across configuration and Docker files.

Poem

A rabbit checks the toolchain tune,
Rust and Alpine rise with the moon.
go-task joins each test-built trail,
Old image steps leave no detail.
The builder hops when images fail.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the primary changes: upgrading the Rust toolchain and Alpine base image versions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docker

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Cargo.toml`:
- Line 4: Update the Rust toolchain versions in the CI workflows rust.yml and
release.yml from 1.93.0 to 1.96.1, matching the project’s rust-version and
rust-toolchain.toml requirements.

In `@README.md`:
- Line 23: Remove the shell prompt marker from the changed cargo installation
command and the adjacent dela init command in the README command block, leaving
only the executable commands.

In `@tests/docker_unit/Dockerfile`:
- Line 5: Update the direct unit-test runner flow in run_tests.sh so it builds
or otherwise ensures the dela-builder image exists when BUILDER_IMAGE is unset,
matching the existing make test_unit and CI behavior before using
tests/docker_unit/Dockerfile. Preserve support for explicitly provided
BUILDER_IMAGE values.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: bac8e43c-b4fa-4610-a39e-fe465ede19ee

📥 Commits

Reviewing files that changed from the base of the PR and between 5c4d97e and 700c067.

📒 Files selected for processing (12)
  • Cargo.toml
  • Makefile
  • README.md
  • dev_docs/testing.md
  • rust-toolchain.toml
  • tests/Dockerfile.builder
  • tests/docker_bash/Dockerfile
  • tests/docker_fish/Dockerfile
  • tests/docker_noinit/Dockerfile
  • tests/docker_pwsh/Dockerfile
  • tests/docker_unit/Dockerfile
  • tests/docker_zsh/Dockerfile

Comment thread Cargo.toml
Comment thread README.md Outdated
Comment thread tests/docker_unit/Dockerfile
@aleyan
aleyan merged commit fc1df95 into main Aug 12, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant