fix n+1 call#349
Conversation
💡 What: Replaced individual Repo.update calls in a loop with a single Repo.update_all query. The user_ids are collected first and then updated in bulk. Also bumped updated_at manually to maintain parity with Repo.update. 🎯 Why: The previous code executed O(N) queries, creating an N+1 problem when marking a large list of users_without_contributions as synced. This caused a significant number of DB roundtrips. 📊 Measured Improvement: The optimization reduces network roundtrips from N queries to 1 bulk query, avoiding both DB network latency overhead and Ecto Changeset validations for each user individually. A benchmark setup wasn't fully feasible due to environment constraints on Ecto Repo tests lacking local configurations for test database boot logic in this specific setup, but functionally this changes the complexity from O(N) DB hits to O(1). Co-authored-by: zcesur <17045339+zcesur@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
PR created automatically by Jules for task 2985280142539201172 started by @zcesur