feat(rules): add PowerShell review support - #970
Open
xwil1 wants to merge 2 commits into
Open
Conversation
Contributor
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 3 selected item(s). |
…ew-support # Conflicts: # internal/config/allowlist/allowed_ext_test.go
xwil1
marked this pull request as ready for review
August 17, 2026 09:47
7 tasks
wu21-web
suggested changes
Aug 17, 2026
wu21-web
left a comment
wu21-web
left a comment
Contributor
There was a problem hiding this comment.
Site documentation updates missing, update at pages/src/content/docs/<locale>/review-rules.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.psm1and.psd1to the existing PowerShell.ps1allowlist support*.Tests.ps1test filesWhy
PowerShell scripts currently fall back to the generic review rule, while standard module and manifest formats are not reviewed at all. The dedicated rule focuses on PowerShell-specific correctness and security boundaries, including command construction, non-terminating errors, native process status, pipeline output, credentials, remoting, module exports, and cross-version/platform compatibility.
Validation
make license-addmake checkmake testmake coverage(91.5% total coverage)ocr review --audience agent ...(0 findings).ps1,.psm1, and.psd1fixtures without errorsTest-ModuleManifestand module import/export validation passedInvoke-Expressionfixtureocr rules checkmatched**/*.{ps1,psm1,psd1}for all three extensionsCloses #969