feat(allowlist): add Mojo support - #977
Open
wakqasahmed wants to merge 1 commit into
Open
Conversation
Add .mojo and .🔥 to the supported file types allowlist, a mojo.md review rule doc covering ownership/borrowing (borrowed/inout/owned, transfer semantics, copyinit/moveinit/del), unsafe pointer and FFI interop, the PythonObject boundary, parallelize/vectorize concurrency hazards, and Mojo-specific performance anti-patterns, and register the glob-to-rule mapping in system_rules.json. No conventional test-file exclusion pattern exists for Mojo yet. Part of the language-allowlist expansion tracked in alibaba#470.
Contributor
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 2 selected item(s). |
wu21-web
suggested changes
Aug 17, 2026
wu21-web
left a comment
wu21-web
left a comment
Contributor
There was a problem hiding this comment.
Site documentation updates missing, update at pages/src/content/docs/<locale>/review-rules.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.mojoand.🔥to the supported file types allowlistallowed_ext_test.godocuments this explicitly (matching the existing Prisma/Shader precedent)internal/config/rules/rule_docs/mojo.md, a Mojo review rule doc covering ownership/borrowing conventions (borrowed/inout/ownedargument mismatches, unintended transfers with^,__copyinit__/__moveinit__/__del__correctness), value semantics and struct design, unsafe pointer and C/Python FFI interop, thePythonObjectinterop boundary,parallelize/vectorizeconcurrency hazards, Mojo-specific performance anti-patterns, and security-sensitive raw-pointer/deserialization concerns**/*.{mojo,🔥} -> mojo.mdinsystem_rules.jsonPart of the language-allowlist expansion tracked in #470.
Closes #976
Test plan
go test ./internal/config/allowlist/... -run 'TestIsAllowedExt|TestIsExcludedPath' -v— PASSgo test ./internal/config/rules/... -run TestResolve_DefaultRules -v— PASSgofmt -s -l .— cleango vet ./internal/config/...— cleango run scripts/verify-english-only.go— clean (423 files scanned, no unapproved non-English text)