Add multi-level link expansion for edition links - #4153
Draft
brucebolt wants to merge 6 commits into
Draft
Conversation
Between the last commit and this one, ADR-009 was added. This removes the need for many of the joins we previously had. https://github.com/alphagov/publishing-api/blob/main/docs/arch/adr-009-change-linksets-primary-key-to-content-id.md
This makes a few of the tests pass. I'm not really sure why.
This matches the change made in 4dbf067
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| SELECT nested_links.id | ||
| FROM links AS nested_links | ||
| WHERE nested_links.link_set_content_id = links.target_content_id | ||
| #{and_not_parent('nested_links.target_content_id')} |
| SELECT nested_links.id | ||
| FROM links AS nested_links | ||
| WHERE nested_links.target_content_id = links.link_set_content_id | ||
| #{and_not_parent('nested_links.target_content_id')} |
| SELECT nested_links.id | ||
| FROM links AS nested_links | ||
| WHERE #{query} | ||
| #{and_not_parent('nested_links.target_content_id')} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #2605, which has been rebased against the main branch.