[PP-7972] Do not retry Delete Publish Intent Job on not found error - #4177
Merged
Conversation
We currently raise a `GdsApi::NotFound` exception when attempting to delete a publish intent which already does not exist in Content Store. This results in the job retrying, even though it will always fail as the publish intent does not exist. If the publish intent does get created again, but then we try to delete it, we attempt to schedule another job but that fails because of the lock that has been readded. The retries occur over a period of 20 days, meaning deletion of a publish intent could potentially be blocked for that period. Changing the logic here to rescue from this exception and log the error instead of failing. This will mean the job doesn't get added to the retry queue and won't remain locked.
brucebolt
marked this pull request as ready for review
August 26, 2026 12:37
callumknights
approved these changes
Aug 26, 2026
brucebolt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently raise a
GdsApi::NotFoundexception when attempting to delete a publish intent which already does not exist in Content Store.This results in the job retrying, even though it will always fail as the publish intent does not exist.
If the publish intent does get created again, but then we try to delete it, we attempt to schedule another job but that fails because of the lock that has been readded.
The retries occur over a period of 20 days, meaning deletion of a publish intent could potentially be blocked for that period.
Changing the logic here to rescue from this exception and log the error instead of failing. This will mean the job doesn't get added to the retry queue and won't remain locked.